Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Angular's $location service #347

Closed
trepagnier opened this issue Dec 3, 2018 · 1 comment
Closed

Replace Angular's $location service #347

trepagnier opened this issue Dec 3, 2018 · 1 comment
Assignees
@trepagnier
Milestone
Sprint 12 3 Decem...

Comments

@trepagnier
Copy link
Contributor

The use of Angular's $location object should be replaced. Make sure the tests still pass for all the chapter navigation stuff. This will involve mocking the path behavior. We should create our own $Path substitute in the utility module that exposes the same API and produces the same output to avoid rewriting code/tests.
@trepagnier trepagnier self-assigned this Dec 3, 2018
@trepagnier
Copy link
Contributor Author

Working this ticket on branch: https://github.com/MapStory/story-tools-composer/tree/dja-replace-location-svc

@trepagnier trepagnier mentioned this issue Dec 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trepagnier trepagnier

Labels
None yet
Projects
None yet
Milestone
Sprint 12 3 December - 16 December
Development

No branches or pull requests
1 participant
@trepagnier