Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Angular $location service. #348

Merged
merged 4 commits into from
Dec 7, 2018
Merged

Conversation

trepagnier
Copy link
Contributor

This PR:

  • Replaces the Angular $location svc with our own more lightweight alternative.
  • Cleans up various linting errors.

Note the @todo in the navigationSvc:

// locationSvc is being hitched to navigationSvc temporarily in order
// for Karma tests to have acces.
// @TODO: remove locationSvc after karma tests have been configured to
// import ES6 modules.

R e s #347

Copy link
Contributor

@shawnkendrick shawnkendrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slick

@cuttlefish
Copy link
Member

CodeFactor found an issue: 'location' is assigned a value but never used.

It's currently on:
app\ui\spec\navigationSvc.spec.js:5
Commit 788b88f

@cuttlefish
Copy link
Member

Maybe just delete that uneeded location? Otherwise looks good

@cuttlefish cuttlefish merged commit 8e5f652 into master Dec 7, 2018
@cuttlefish cuttlefish deleted the dja-replace-location-svc branch December 9, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants