Fix: Vroom cannot handle activity positions

test/wrapper_test.rb

@@ -2129,6 +2129,18 @@ def test_wrong_matrix_and_points_definitions
     assert_includes OptimizerWrapper.config[:services][:vroom].inapplicable_solve?(vrp), :assert_correctness_matrices_vehicles_and_points_definition
   end
 
+  def test_activity_position_presence
+    problem = VRP.basic
+    vrp = TestHelper.create(problem)
+    refute_includes OptimizerWrapper.config[:services][:ortools].inapplicable_solve?(vrp), :assert_no_activity_with_position
+    refute_includes OptimizerWrapper.config[:services][:vroom].inapplicable_solve?(vrp), :assert_no_activity_with_position
+
+    problem[:services].first[:activity][:position] = 'always_last'
+    vrp = TestHelper.create(problem)
+    refute_includes OptimizerWrapper.config[:services][:ortools].inapplicable_solve?(vrp), :assert_no_activity_with_position
+    assert_includes OptimizerWrapper.config[:services][:vroom].inapplicable_solve?(vrp), :assert_no_activity_with_position
+  end
+
   def test_unassigned_presence
     problem = {
       units: [{

wrappers/vroom.rb

@@ -58,6 +58,7 @@ def solver_constraints
         :assert_vehicles_start_or_end,
 
         # Mission constraints
+        :assert_no_activity_with_position,
         :assert_no_direct_shipments,
         :assert_no_exclusion_cost,
         :assert_no_complex_setup_durations,

wrappers/wrapper.rb

@@ -274,6 +274,12 @@ def assert_wrong_vehicle_shift_preference_with_heuristic(vrp)
       (vrp.vehicles.map(&:shift_preference).uniq - [:minimize_span] - ['minimize_span']).empty? || vrp.preprocessing_first_solution_strategy.to_a.first != 'periodic'
     end
 
+    def assert_no_activity_with_position(vrp)
+      vrp.services.none?{ |service|
+        (service.activities.to_a + [service.activity]).compact.any?{ |a| a.position != :neutral }
+      }
+    end
+
     def assert_no_vehicle_overall_duration_if_heuristic(vrp)
       vrp.vehicles.none?(&:overall_duration) || vrp.preprocessing_first_solution_strategy.to_a.first != 'periodic'
     end