Merge pull request #111 from senhalil/feat/infeasible_service_with_ne…

…gative_quantity

Fix: eliminate negatif infeasible quantities

CHANGELOG.md

@@ -15,10 +15,15 @@
 - Bump OR-Tools v7.8 [#107](https://github.com/Mapotempo/optimizer-api/pull/107)
 - VROOM were previously always called synchronously, it is now reserved to a set of effective `router_mode` (:car, :truck_medium) within a limit of points (<200). [#107](https://github.com/Mapotempo/optimizer-api/pull/107)
 
+### Removed
+
+
 ### Fixed
 
 - `unassigned` output were in some cases returning the key `shipment_id` instead of `pickup_shipment_id` and `delivery_shipment_id` [#107](https://github.com/Mapotempo/optimizer-api/pull/107)
 - Uniformize route content and always return `original_vehicle_id` [#107](https://github.com/Mapotempo/optimizer-api/pull/107)
+- Infeasibility detection of services with negative quantity [#111](https://github.com/Mapotempo/optimizer-api/pull/111)
+
 
 ## [v0.1.5] - 2021-01-05
 

test/test_helper.rb

@@ -202,6 +202,7 @@ def self.vehicle_and_days_partitions
 module VRP # rubocop: disable Metrics/ModuleLength, Style/CommentedKeyword
   def self.toy
     {
+      units: [{ id: 'u1' }],
       points: [{
         id: 'p1',
         location: {

test/wrapper_test.rb

@@ -2820,6 +2820,17 @@ def test_impossible_service_too_long
     assert_empty OptimizerWrapper.config[:services][:demo].detect_unfeasible_services(TestHelper.create(vrp))
   end
 
+  def test_impossible_service_with_negative_quantity
+    vrp = VRP.toy
+    vrp[:services].first[:quantities] = [{ unit_id: 'u1', value: -5 }]
+    vrp[:vehicles].first[:capacities] = [{ unit_id: 'u1', limit: 5 }]
+    assert_empty OptimizerWrapper.config[:services][:demo].detect_unfeasible_services(TestHelper.create(vrp))
+
+    vrp[:services].first[:quantities].first[:value] = -6
+    result = OptimizerWrapper.config[:services][:demo].detect_unfeasible_services(TestHelper.create(vrp))
+    assert_equal(1, result.count{ |un| un[:reason] == 'Service quantity greater than any vehicle capacity' })
+  end
+
   def test_feasible_if_tardiness_allowed
     vrp = VRP.basic
 

wrappers/wrapper.rb

@@ -750,7 +750,7 @@ def detect_unfeasible_services(vrp)
 
       vrp.services.each{ |service|
         service.quantities.each{ |qty|
-          if vehicle_max_capacities[qty.unit_id] && qty.value && vehicle_max_capacities[qty.unit_id] < qty.value
+          if vehicle_max_capacities[qty.unit_id] && qty.value && vehicle_max_capacities[qty.unit_id] < qty.value.abs
             add_unassigned(unfeasible, vrp, service, 'Service quantity greater than any vehicle capacity')
             break
           end