-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fakeredis count system #114
Fix fakeredis count system #114
Conversation
be71345
to
112383e
Compare
112383e
to
16e1047
Compare
@alain-andre I don't know why you tagged me for rubocop? Rubocop rules are changed in PR #68 and it is merged recently without fixing the new errors due changed rules. I am not surprised that it fails. |
Ok, I did not notice this, I still had in mind that fixing rubocop to v1.81 was enough not to break tests. I'll check. |
Don't know about the rubocop version, I don't remember when I touched it last time. However, I know that two days ago when I created PR #111 and pushed commit 3a696e9 rubocop test was okay (because I have a git-hook which verifies this) and it still is okay at that moment in time.
|
a41c54f
to
43e0881
Compare
e5f1bf2
to
0cc29b4
Compare
If I do |
Yes you are right, I forgot to remove the gem limitations in lock file, I'm updating the commit. |
463620f
to
5eb2a5c
Compare
5eb2a5c
to
8f54358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
white-space typos otherwise 👌
Co-authored-by: senhalil <halil.sen@mapotempo.com>
Fix error due to fakeredis and use a real one like other tests. It fixes also some errors like about
status
in returned json (notjob[status]
) and quotas mistake.@fab-girard, @braktar we were not agree where to put the
count_increase
for an optimization, this still can be moved. Do we want to increase the count every time a VRP is valid or only when a full result is given ?The only errors and failures are now due to known
build_detail
method, rubocop (@senhalil), a random time test and array that should be empty.