Rename scheduling to periodic #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
from
3ca32e7
to
f1672f3
Compare
senhalil
reviewed
Apr 8, 2021
|
@fonsecadeline can you merge all the commits of this PR so that renaming is done in one single commit? |
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
2 times, most recently
from
ecfb79c
to
e506ba7
Compare
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
2 times, most recently
from
d6507dd
to
f585342
Compare
braktar
suggested changes
Apr 21, 2021
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
2 times, most recently
from
5406d64
to
4fe4411
Compare
braktar
suggested changes
Apr 26, 2021
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
from
4fe4411
to
d26789a
Compare
braktar
approved these changes
Apr 26, 2021
senhalil
approved these changes
Apr 27, 2021
|
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
from
d26789a
to
5ecc6f8
Compare
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
from
5ecc6f8
to
7dfcc1f
Compare
I don't know, the heuristic was always called periodic on the user side, so there is no change from their point of view. From the dev point of view, it doesn't sound like it deserves to be on the changelog but either way is fine for me. |
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
3 times, most recently
from
6f779a1
to
796afb6
Compare
fonsecadeline
force-pushed
the
rename_scheduling_to_periodic
branch
from
796afb6
to
5d9376d
Compare
senhalil
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.