-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix split independent functions #50
Fix split independent functions #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
e668666
to
fb16cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some issues with compact, delete_if and variable_naming
5e96374
to
ba4358e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The person you have called cannot be reached at the moment, try again later :)
ba4358e
to
bf5066b
Compare
bf5066b
to
0860425
Compare
0860425
to
14742dc
Compare
bbb22ec
to
a7326e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there might be a rebase conflict mistake
a7326e9
to
89ac437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR looks okay but there are broken tests :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgotten assert_correctness_provided_matrix_indices
89ac437
to
1201df9
Compare
optimizer_wrapper.rb
Outdated
# Intead of map{}.compact() or collect{}.compact() reduce([]){} or each_with_object([]){} is more efficient | ||
# when there are items to skip in the loop because it makes one pass of the array instead of two | ||
vrp.vehicles.each_with_index.each_with_object([]) { |(vehicle, v_i), sub_vrps| | ||
vrp.vehicles.each_with_index.collect{ |vehicle, v_i| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map.with_index ?
1201df9
to
9ca90da
Compare
No description provided.