v1: use function to reduce memory usage #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsecadeline
force-pushed
the
memory_usage_reduction
branch
2 times, most recently
from
fb0c8bc
to
8058065
Compare
fonsecadeline
force-pushed
the
memory_usage_reduction
branch
from
8058065
to
35e0042
Compare
senhalil
reviewed
Oct 16, 2020
fonsecadeline
force-pushed
the
memory_usage_reduction
branch
from
35e0042
to
e7d21d9
Compare
Closed
fonsecadeline
force-pushed
the
memory_usage_reduction
branch
from
e7d21d9
to
2a55a12
Compare
fonsecadeline
force-pushed
the
memory_usage_reduction
branch
2 times, most recently
from
a25641e
to
4f21d4d
Compare
braktar
suggested changes
Oct 28, 2020
| # TODO : need to uniformize generated relations whether mission has minimum AND maximum lapse or only one of them | ||
| return unless mission.visits_number > 1 | ||
|
|
||
| if mission.minimum_lapse && mission.maximum_lapse |
There was a problem hiding this comment.
could you factorise the relation definition ? and give the specific mission_ids in a single place. It is a bit difficult to see the distinction between the cases.
There was a problem hiding this comment.
For now the goal was to group code that was identical for shipment and services.
I would indeed like to factorise but it is not that easy because of https://gitlab.com/mapotempo/optimizer-api/-/issues/339 . There can be an impact we need to test.
fonsecadeline
force-pushed
the
memory_usage_reduction
branch
from
a25641e
to
db9cb60
Compare
braktar
suggested changes
Nov 4, 2020
wrappers/ortools.rb
Outdated
| @@ -472,7 +472,7 @@ def build_costs(costs) | |||
|
|
|||
| def check_services_compatible_days(vrp, vehicle, service) | |||
| if vrp.schedule_range_indices && (service.minimum_lapse || service.maximum_lapse) | |||
| (vehicle.global_day_index >= service[:first_possible_day] && vehicle.global_day_index <= service[:last_possible_day]) ? true : false | |||
| (vehicle.global_day_index >= service[:first_possible_days].first && vehicle.global_day_index <= service[:last_possible_days].first) ? true : false | |||
There was a problem hiding this comment.
The condition already returns true or false ?
There was a problem hiding this comment.
The content of the function could be replaced with:
!vrp.schedule_range_indices || (!service.minimum_lapse && !service.maximum_lapse) ||
(vehicle.global_day_index >= service[:first_possible_days].first && vehicle.global_day_index <= service[:last_possible_days].first)
db9cb60
to
90baa85
Compare
braktar
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.