Add lapse in vehicle_trips relation #20
Conversation
fonsecadeline
force-pushed
the
multi_tour_with_lapse
branch
from
92e437b
to
48783c6
Compare
fonsecadeline
force-pushed
the
multi_tour_with_lapse
branch
from
48783c6
to
3f4583f
Compare
|
@senhalil we initially had 'lapse' because it was initially used for mini/maximum day lapse (between visits). We could consider renaming it but either we have a different internal and external name for this relation.lapse, or we need to change fields for users (even though I am not sure much users use this field). |
|
If that was the reason, we should definitely rename the internal variable (because it doesn't do what the name suggests) but also, when we have time, we can "deprecate" the |
|
@fonsecadeline do you want to attack on the renaming here? I think its better if you create a ticket for the |
|
@senhalil I agree, like this we can consider to merge this (which is needed for multi-tour) as soon as I get back. Can you create the ticket ? |
|
Don't know why do you want me to create the ticket, my message was clear |
|
@senhalil but it is your idea. |
|
I was the following up on the idea from your comment and I asked if you want to do the renaming here and gave my opinion that I think its better if you created a ticket. I think if a PR needs an action, it should be the creator of the PR who should take the action if they are able to. |
|
@senhalil there has been a misunderstood here. I felt you had a very clear idea of what we need to do that is why it would have make more sense for me if you wrote the ticket. From my point of view, if a PR pops an idea then the one with the suggestion could create the ticket. Mais bref, this is not very important, and just a matter of point of vue :) the important here is that you approved PR so we can move on. I created general ticket and you can add your comments on it : https://gitlab.com/mapotempo/optimizer-api/-/issues/690. @braktar do you approve this PR too ? |
|
No description provided.