Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature links should delegate focus #580

Closed
Malvoz opened this issue Nov 18, 2021 · 3 comments · Fixed by #607
Closed

Feature links should delegate focus #580

Malvoz opened this issue Nov 18, 2021 · 3 comments · Fixed by #607

Comments

@Malvoz
Copy link
Member

Malvoz commented Nov 18, 2021

Repro steps for https://maps4html.org/experiments/linking/features/:

  1. Tab three times to focus the Prince Edward Island feature
  2. Press Enter to visit the feature link

On step 2:

  • "Interactive map, region" is announced
    Expectation: "Prince Edward Island" is announced
  • The Prince Edward Island feature is not focused (tabbing starts from the map component -> Newfoundland and Labrador -> Prince Edward Island)
    Expectation: Prince Edward Island is focused

Can focus be sent to features after activating feature links?

@prushforth
Copy link
Member

Can focus be sent to features after activating feature links?

I think so. We'll try to fix this.

@ben-lu-uw
Copy link
Contributor

When you first tab to PEI it will announce "Prince Edward Island", and in step 2 you want it to announce it again? Isn't that a bit redundant. @Malvoz

@Malvoz
Copy link
Member Author

Malvoz commented Nov 26, 2021

in step 2 you want it to announce it again?

@ben-lu-uw I guess that's just the effect focus has, and is not unlike e.g:

<!-- links in a table of contents -->
<a href="#cats">Cats</a> <!-- on focus: "Cats" announced -->

<!-- page content -->
<h2 id="cats">Cats</h2> <!-- on focus as a result of following the above link: "Cats" announced -->

Also, I'm not exactly sure how feature links work but I guess a feature can be named one thing but link to a feature with another name, in which case it makes even more sense that the feature name is announced as a result of focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants