Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<map-a> wrapped around <map-geometry> fails when loaded via <map-link rel=features> #967

Closed
prushforth opened this issue Jul 31, 2024 · 0 comments · Fixed by #968
Closed

<map-a> wrapped around <map-geometry> fails when loaded via <map-link rel=features> #967

prushforth opened this issue Jul 31, 2024 · 0 comments · Fixed by #968
Labels
bug

Comments

@prushforth
Copy link
Member

This was discovered by @turingtestfail over here. In contrast, <map-a href="..."><map-geometry> works fine (click on BC Geo Survey HQ marker) when loaded from a text/mapml document directly, or inline within a <layer->...</layer->.

Seems like it should work when loaded via <map-link rel=features>?

Comments below...
prushforth added a commit to prushforth/MapML.js that referenced this issue Jul 31, 2024
@prushforth
Add test html/mapml files against which to test map-a in inline and /or
9c247d7 
remote mapml documents loaded directly or via <map-link rel=features>
added under test/e2e/elements/map-link, but could have been under
new map-a directory tbd

Addresses Maps4HTML#967

Todo: 1) update code 2) write tests 3) update geoserver viewer
@prushforth prushforth mentioned this issue Jul 31, 2024
Merged
3 tasks
@prushforth prushforth added the bug label Jul 31, 2024
prushforth added a commit to prushforth/MapML.js that referenced this issue Aug 12, 2024
@prushforth
Get link in templated feature working. Update
11fef91 
existing test to pass. Add test.

Closes Maps4HTML#967
prushforth added a commit to prushforth/MapML.js that referenced this issue Aug 12, 2024
@prushforth
Get link in templated feature working. Update
dd6793b 
existing test to pass. Add test.

Closes Maps4HTML#967
prushforth added a commit to prushforth/MapML.js that referenced this issue Aug 16, 2024
@prushforth
Get link in templated feature working. Update (Maps4HTML#968)
8486c47 
existing test to pass. Add test.

Closes Maps4HTML#967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@prushforth