Add native appearance to map element(s) #108
Merged
+258
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default size of 300x150px to the map element(s) - Restore default UA outline styles for accessible sequential navigation - Enable author controlled background-color on the map element(s) - Pre-style to mitigate FOUC
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
prushforth
reviewed
Jul 13, 2020
|
Robert: Looks good to me! Thanks for your help. |
Malvoz
added
the
basic styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background-coloron the map element(s)The new default styles together with the pre-styling have been carefully crafted to ensure that:
:definedselector), and with a low CSS specificity such that authors can easily override to customize it (e.g.width,height,border,background-color).(caveat:
<img usemap="">must come after<map>in the DOM order to prevent FOUC).<layer- style="display: none">or<map hidden>on every element to prevent FOUC.@prushforth Please try it out locally (perhaps with added fallback content/inline layers/unsupporting browser and JS disabled to get the full experience 😅) and let me know what you think.