-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructures src directory and implements RollUpJS #128
Conversation
Looks pretty good @ahmadayubi ! I noticed a bunch of errors related to playwrite when running npm install. Are you aware of that? I'll keep playing with it, will let you know if I see anything else. |
Copyright and license notices be embedded in the output *.js files?? Or perhaps in the LICENSE.md or what. Your thoughts on this. |
Are they the same as yours? |
Sorry I ran something else and lost them. No they aren't the same. I'll re run and see if it happens again. |
The same errors didn't happen again, but I get these, which are pretty close. It was related to a zip file of a browser... npm WARN jest-playwright-preset@0.1.3 requires a peer of jest-environment-node@^25.2.3 but none is installed. You must install peer dependencies yourself. |
I'm deleting my node_modules and starting over. |
Maybe having it inside of LICENSE.md might be a good option, not sure. |
Here's what I get on a clean install (no node_modules): "C:\Program Files\nodejs\npm.cmd" "install"
(node:6984) UnhandledPromiseRejectionWarning: Error: EPERM: operation not permitted, unlink 'C:\Users\prushfor\AppData\Local\Temp\playwright-download-webkit-win64-1301.zip' more non-critical stuff here. |
I'll get rid of that file and run it again. |
All clear, must be an issue with re-installing playwright. |
This reverts commit 749173c.
Closes #120
Splits the mapml.js file into several files in the following heirarchy:
src
├── mapml
│ ├── handlers
│ │ ├── ContextMenu.js
│ │ └── QueryHandler.js
│ ├── layers
│ │ ├── ControlLayer.js
│ │ ├── FeatureLayer.js
│ │ ├── ImageLayer.js
│ │ ├── MapLayer.js
│ │ ├── StaticTileLayer.js
│ │ ├── TemplatedFeaturesLayer.js
│ │ ├── TemplatedImageLayer.js
│ │ ├── TemplatedLayer.js
│ │ └── TemplatedTileLayer.js
│ ├── utils
│ │ ├── Constants.js
│ │ └── Util.js
│ └── index.js
├── layer.js
├── map-area.js
├── mapml.css
├── mm-mapp.js
└── web-map.js
To build the entire project including mapml.js inside /dist, run the same grunt task as before (grunt / default).
To generate mapml.js only inside of /dist, run grunt / build.
The PR contains 50+ commits that were necessary according to the following link:
Splitting a file while preserving line history