Connect first and last points of a outline using modulo #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, sorry for the painful experience! Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases renders as:
Cause of issue:
Needed to preform modulo when generating outline, without it the first and last coordinate pairs in a coordinates element didn't behave appropriately. Coordinates for a polygon are better thought of as a circular linked list rather than a sequence with a start and an end.
On a side node, the behavior of
%operator in JavaScript is not consistent at all, occasionally -1 % 4 = 3 and other times -1 % 4 = -1, there's a work around in this PR for it but it's odd nonetheless.Closes #368