Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer control Accessibility Bug Fixes #591

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

Anshpreet8
Copy link
Contributor

Fixed the following issues:

  • shift the focus to first layer entry upon pressing enter to open the layer control
  • shift focus to layer context menu when it's opened and shift focus back to the layer entry when it's closed

Closes #578

@prushforth
Copy link
Member

LGTM - nice work

@prushforth prushforth requested a review from Malvoz November 23, 2021 13:19
@Malvoz
Copy link
Member

Malvoz commented Nov 23, 2021

I noticed 2 things:

  • If I shift + tab after the context menu has been opened focus always returns to the layer checkbox, it'd be good if focus instead returned to the button that was previously focused before opening the menu, for example the Layer Settings button.
  • Pressing esc closes the context menu and the map is focused instead

@Anshpreet8
Copy link
Contributor Author

@prushforth using the shadowRoot allowed me to get the current element in focus, I have accordingly made the suggested fixes

Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@prushforth prushforth merged commit a6e7c00 into Maps4HTML:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer context menu is not focused / announced when Shift-F10 is pressed with focus on layer item
3 participants