Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature index #636

Merged
merged 31 commits into from
May 27, 2022
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7503bb9
Add feature indexing
ben-lu-uw Dec 13, 2021
28b3a33
Toggle feature index on or off
ben-lu-uw Dec 14, 2021
428c22e
Toggle feature index on or off
ben-lu-uw Dec 14, 2021
364442c
Check overlap on focus
ben-lu-uw Dec 15, 2021
7b73f0b
Fix function name
ben-lu-uw Dec 15, 2021
2772b20
Replace table with output element
ben-lu-uw Dec 15, 2021
54c9e6a
Add CSS for 'more results'
ben-lu-uw Dec 16, 2021
6e44a18
Limit output to having 9 items at a time
ben-lu-uw Dec 17, 2021
b080af2
Optimize the SVG using SVGOMG
ben-lu-uw Dec 17, 2021
a7f1af0
Optimize the SVG using SVGOMG
ben-lu-uw Dec 17, 2021
7e361ef
Hide output when empty
ben-lu-uw Dec 17, 2021
64fb95f
Adding thin outline to reticle
ben-lu-uw Dec 17, 2021
ef177f9
Focus on feature when number key is pressed
ben-lu-uw Dec 20, 2021
6d02a1a
Refactor code
ben-lu-uw Dec 20, 2021
bd9ac2a
Fix focusing on feature when number key is pressed
ben-lu-uw Dec 20, 2021
ef0d304
Fix failing tests
ben-lu-uw Dec 21, 2021
b6ec7ce
Add feature index overlay tests
ben-lu-uw Dec 21, 2021
ecd0a5b
Make esc key return focus to leaflet container
ben-lu-uw Dec 21, 2021
464969e
Increase reticle size, update tests
ben-lu-uw Dec 22, 2021
04db697
Update feature index overlay output
ben-lu-uw Dec 23, 2021
4445e69
change feature index font
ben-lu-uw May 2, 2022
a795264
Update span attribute
ben-lu-uw May 2, 2022
e6bec6a
Add feature index overlay option
ben-lu-uw May 3, 2022
c2c88e8
Fix cs of us_pop_density.mapml
ben-lu-uw May 3, 2022
2e43c86
Improve feature index styling for visual users (#1)
ben-lu-uw May 9, 2022
bedc2ae
Fix index popup issue + make sure index keys are valid onKeyDown
ben-lu-uw May 19, 2022
621f15f
Fix tabbing issue + add popup test
ben-lu-uw May 19, 2022
36ba188
Change popup behaviour
ben-lu-uw May 19, 2022
215b4c0
Remove features from tabindex when FeatureIndexOverlay is enabled
ben-lu-uw May 20, 2022
12a6616
Update feature index screen reading behavior (#2)
ben-lu-uw May 26, 2022
b0e233f
Hide reticle when popup is open
ben-lu-uw May 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Hide reticle when popup is open
  • Loading branch information
ben-lu-uw committed May 27, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b0e233f71b4e1bdd4d5be6da843a44566e80618f
2 changes: 1 addition & 1 deletion src/mapml/layers/FeatureIndexOverlay.js
Original file line number Diff line number Diff line change
@@ -183,7 +183,7 @@ export var FeatureIndexOverlay = L.Layer.extend({
this._container.setAttribute("hidden", "");
this._output.classList.add("mapml-screen-reader-output");
} else if (e && e.target._popup) {

this._container.setAttribute("hidden", "");
} else if (e && e.type === "blur") {
this._container.setAttribute("hidden", "");
this._output.classList.add("mapml-screen-reader-output");