-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy location as <map-feature> #804
Copy location as <map-feature> #804
Conversation
Change Util._pasteLayer to sniff for <map-feature, paste as a visible layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I should DRY the <map-feature>
boilerplate, to avoid .js bloat. Also need to localize strings via mapml-extension PR.
How should we deal with the different "Coordinate system for location" options, for ex. I am not sure how helpful it would be to copy "tilematrix", "map" and "tile" as a |
I think for now I will log a message to the console, open an issue to fix this when the |
@AliyanH do you think the behavior is ok as far as pasting a new layer each time goes, or should it paste into an existing layer? Of course that will only work once the |
I think it makes sense to paste as a new layer with the localized label when pasting on to the viewer. Maybe in the future we can paste into layers through the layer control contextmenu? Though the label you put for pasting features made me wonder, if we should change the default label for pasting layers/geojson with no label (to something similar: "Pasted layer"), currently it defaults to a localized string of: "Layer" |
not implemented yet, uses gcrs as substitute location for those.
Depends on Maps4HTML/mapml-extension#54 for localization. |
@AliyanH :
Makes sense. I may update this and related PR to do that, tbd. |
Closes #779