-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Zoom to here" link in popup #831
Conversation
@yhy0217 I put a build of this into GeoServer to test it against queryable layers, and I get the following on a query that should return a On the referenced line 401 of mapml.js, feature._extentEl.shadowRoot.firstChild?.remove(); the ._extentEl is null The document returned by the query is: -big, not relevant |
was mistaken, it's the shadowRoot property of ._extentEl that is null |
'Zoom to here' link, no errors.
…nt and map-feature
Closes #778 |
This is really working well now - the custom projection query is even working on the shrink/swell layer - reveals a "Zoom to here" link that works - thanks for working on this, too, @AliyanH. Also, I noticed that the extension's "Zoom to here" link is working correctly now, for example when rendering a GeoServer WFS layer, the zoom to here link is correct. Overall, this is excellent work. I'll keep reviewing, but I think it's ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Seems like the popup is hard to get rid of after clicking on the "Zoom to here" link, check the restaurants experiment. |
Closes #778