Skip to content

Programmatically identifiable map #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2020
Merged

Programmatically identifiable map #151

merged 2 commits into from
Aug 29, 2020

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Aug 22, 2020

Gives the focusable .leaflet-container a descriptive accessible name, as well as a role of region. See inline comments for the upstream Leaflet issue for more details.

@Malvoz Malvoz requested a review from prushforth August 22, 2020 17:43
@prushforth
Copy link
Member

I certainly endorse the idea of announcing that the <map> or <mapml-viewer> has a role and/or accessible name that is appropriate. I wonder if we should not be specifying this in MapML as well. I would think that <map> / <mapml-viewer> element should carry these properties?

I think maybe we need to define/propose a new role such as interactive-map, or more simply "map" (that's not taken by programmers yet, is it?), because maps should be an accessibility tool for the real world. IIUC then you wouldn't need the aria-role??

Maybe @nchan0154 could comment, too, since I'm way way out of my depth here. In general I am +1 on this.

Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@nchan0154
Copy link

Disclaimer, I am certainly not an expert on the spec side of things, but I agree with your instincts @prushforth. What makes most sense to me is that a native <map> element is announced as such (or something similar that would imply the implicit functionality a map has such as zooming and panning). Additionally, because a native map element would not replace all custom web maps, a new role should also be suggested as region is the most fitting right now and that isn't all that descriptive.

@Malvoz
Copy link
Member Author

Malvoz commented Aug 29, 2020

I think maybe we need to define/propose a new role such as interactive-map, or more simply "map" (that's not taken by programmers yet, is it?)

There's no implicit role of <map> today, but that may change, see w3c/aria#698.

@nchan0154 I agree - and thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants