-
Notifications
You must be signed in to change notification settings - Fork 16
Alignment improvements in the Layer control #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment improvements in the Layer control #565
Conversation
Also remove unnecessary `width` and `!important` statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the alignment changes as it makes it more consistent but I guess it's up to preference.
The original indentation was intentional, but I don't remember if not indenting the opacity slider was intentional or not. I think the logical thing is to either indent all input controls or don't indent any. While I think indenting looks better when you expand all details elements, it kind of looks strange with only having the opacity slider visible: as opposed to: It's not a big deal I guess, but if you prefer one thing over the other let me know. 🙂 |
I prefer the indented version. Thanks! |
@prushforth I've indented all the settings (including opacity slider) in 15d3ed4: Feel free to merge, or let me know if there's anything else. 👍 |
Looks good! |
While I'm at it, pushed b6f59f0 to give the layer item name some padding in the block direction ( Before: After: (the effect of the padding is only visible if the layer name is long enough / layer name's container is small enough that the layer name wraps and exceeds the height of the container) |
user-select
styleswidth
and the need for an!important
statement)Before:
After:
text-align
on the layer name (because it 1: doesn't appear to be needed, and 2: doesn't look good if the map is set to RTL direction but the layer name is in an LTR script)Before:
After:
(i.e. now looks good independently of the direction of the map and/or the script used in the layer name, tested using sample arabic text)
Before:
After: