Mapster.Tool catch ReflectionTypeLoadException #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EniacMlezi
commented
Feb 14, 2023
|
|
||
| namespace Mapster.Utils | ||
| { | ||
| static class Extensions | ||
| public static class Extensions |
There was a problem hiding this comment.
Made this public to use from Mapster and Mapster.Tool. Maybe not ideal if it gets published?
There was a problem hiding this comment.
Looks fine to me to be honest, nothing problematic being exposed in that class.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into Mapster.Tool reflection issues. Docker debug builds (Fastmode enabled, windows build) were succeeding, but release builds (Fastmode disabled, linux build) were failing. Don't know exactly why ReflectionTypeLoadException was occuring when loading certain types from an Assembly, but mr Jon Skeet gave a beautiful (/s) piece of code to filter these exceptions out and continue with all types that loaded successfully: https://stackoverflow.com/a/7889272.
I'm afraid this also might filter out IRegister Types, but I'm not too familiar with the way
Assembly.Load()and.GetTypes()work.Possibly fixes:
#368
#467
#455
#513