Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable prototype methods when disabled #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricMCornelius
Copy link

Currently the prototype additions to string don't seem to be disabled appropriately when not in a tty session. Following test case demonstrates:

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % cat test.js 
#!/usr/bin/env node

var colors = require('colors');
console.log(colors.enabled);

console.log('test'.red);

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js 
true
test [red]

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js --no-color
false
test [red]

Currently the prototype additions to string don't seem to be disabled appropriately when not in a tty session.  Following test case demonstrates:

```
ecornelius@ecornelius-T5-XE ~/Repositories/Posh % cat test.js 
#!/usr/bin/env node

var colors = require('colors');
console.log(colors.enabled);

console.log('test'.red);

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js 
true
test [red]

ecornelius@ecornelius-T5-XE ~/Repositories/Posh % ./test.js --no-color
false
test [red]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant