Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue support for nodejs 0.x #213

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Feb 14, 2018

See #212

@paladox paladox changed the title Discontinue support for nodejs 0.x and add support for modern nodejs … Discontinue support for nodejs 0.x and add support for modern nodejs releases Feb 14, 2018
@paladox
Copy link
Contributor Author

paladox commented Feb 14, 2018

cc @DABH

@paladox paladox changed the base branch from master to develop February 14, 2018 00:41
@paladox paladox changed the title Discontinue support for nodejs 0.x and add support for modern nodejs releases Discontinue support for nodejs 0.x Feb 14, 2018
@DABH
Copy link
Contributor

DABH commented May 5, 2018

@Marak at what point (if ever) would you be willing to discontinue support for Node 0.x? Related: https://nodesource.com/node-by-numbers . I believe some of those ancient Node versions might have security issues too. I don't have a strong preference to drop support, but it would provide some benefits (e.g. some dev tools e.g. eslint don't play well with old Node, we can't use ES2015 syntax like let/const, etc.). Interested in your philosophy on this!

@Marak
Copy link
Owner

Marak commented May 5, 2018

I'm okay with dropping support for 0.x node versions for future versions of colors.

I guess we can force new node versions for next major release of colors. Older nodes can always use the previous version if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants