fix(android): better device failure handling for ScreenRecorder (#968)

MarathonLabs · Aug 22, 2024 · 861ce58 · 861ce58
1 parent ff74a7e
commit 861ce58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/...r/vendor-android/src/main/kotlin/com/malinskiy/marathon/android/adam/AdamAndroidDevice.kt b/...r/vendor-android/src/main/kotlin/com/malinskiy/marathon/android/adam/AdamAndroidDevice.kt
@@ -430,8 +430,10 @@ class AdamAndroidDevice(
             }
         } catch (e: CancellationException) {
             logger.warn(e) { "screenrecord start was interrupted" }
+            throw e
         } catch (e: Exception) {
             logger.error("Unable to start screenrecord", e)
+            throw e
         }
     }
 

diff --git a/...src/main/kotlin/com/malinskiy/marathon/android/executor/listeners/video/ScreenRecorder.kt b/...src/main/kotlin/com/malinskiy/marathon/android/executor/listeners/video/ScreenRecorder.kt
@@ -16,8 +16,10 @@ internal class ScreenRecorder(
             startRecordingTestVideo(remoteFilePath)
         } catch (e: CancellationException) {
             logger.warn(e) { "screenrecord start was interrupted" }
+            throw e
         } catch (e: Exception) {
             logger.error("Something went wrong while screen recording", e)
+            throw e
         }
     }