Move SHA1 type to interface

Marc-Bernard-Tools · Feb 3, 2023 · a394a80 · a394a80
1 parent c92a254
commit a394a80
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 8 deletions.
diff --git a/src/zcl_abaplint_abapgit_ext_agent.clas.abap b/src/zcl_abaplint_abapgit_ext_agent.clas.abap
@@ -32,7 +32,7 @@ CLASS zcl_abaplint_abapgit_ext_agent DEFINITION
         zcx_abapgit_ajson_error.
     METHODS get_check_runs
       IMPORTING
-        !iv_commit     TYPE zcl_abaplint_abapgit_ext_exit=>ty_sha1
+        !iv_commit     TYPE zif_abaplint_abapgit_ext=>ty_sha1
       RETURNING
         VALUE(ri_json) TYPE REF TO zif_abapgit_ajson
       RAISING

diff --git a/src/zcl_abaplint_abapgit_ext_chkrn.clas.abap b/src/zcl_abaplint_abapgit_ext_chkrn.clas.abap
@@ -23,7 +23,7 @@ CLASS zcl_abaplint_abapgit_ext_chkrn DEFINITION
     METHODS constructor
       IMPORTING
         !iv_url    TYPE string
-        !iv_commit TYPE zcl_abaplint_abapgit_ext_exit=>ty_sha1
+        !iv_commit TYPE zif_abaplint_abapgit_ext=>ty_sha1
       RAISING
         zcx_abapgit_exception .
     METHODS get
@@ -35,7 +35,7 @@ CLASS zcl_abaplint_abapgit_ext_chkrn DEFINITION
   PRIVATE SECTION.
 
     DATA mv_url TYPE string .
-    DATA mv_commit TYPE zcl_abaplint_abapgit_ext_exit=>ty_sha1 .
+    DATA mv_commit TYPE zif_abaplint_abapgit_ext=>ty_sha1 .
 
 ENDCLASS.
 

diff --git a/src/zcl_abaplint_abapgit_ext_exit.clas.abap b/src/zcl_abaplint_abapgit_ext_exit.clas.abap
@@ -5,10 +5,6 @@ CLASS zcl_abaplint_abapgit_ext_exit DEFINITION
 
   PUBLIC SECTION.
 
-    CONSTANTS c_version TYPE string VALUE '1.2.0' ##NEEDED.
-
-    TYPES ty_sha1 TYPE c LENGTH 40.
-
     CLASS-METHODS get_instance
       RETURNING
         VALUE(ro_instance) TYPE REF TO zcl_abaplint_abapgit_ext_exit.
@@ -106,7 +102,7 @@ CLASS zcl_abaplint_abapgit_ext_exit IMPLEMENTATION.
     DATA:
       lx_error       TYPE REF TO zcx_abapgit_exception,
       lo_repo_online TYPE REF TO zcl_abapgit_repo_online,
-      lv_commit      TYPE ty_sha1,
+      lv_commit      TYPE zif_abaplint_abapgit_ext=>ty_sha1,
       ls_wall        TYPE ty_wall,
       lo_check_run   TYPE REF TO zcl_abaplint_abapgit_ext_chkrn,
       ls_check_run   TYPE zcl_abaplint_abapgit_ext_chkrn=>ty_check_run,

diff --git a/src/zif_abaplint_abapgit_ext.intf.abap b/src/zif_abaplint_abapgit_ext.intf.abap
@@ -0,0 +1,7 @@
+INTERFACE zif_abaplint_abapgit_ext PUBLIC.
+
+  CONSTANTS c_version TYPE string VALUE '1.2.1' ##NEEDED.
+
+  TYPES ty_sha1 TYPE c LENGTH 40.
+
+ENDINTERFACE.
diff --git a/src/zif_abaplint_abapgit_ext.intf.xml b/src/zif_abaplint_abapgit_ext.intf.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_INTF" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <VSEOINTERF>
+    <CLSNAME>ZIF_ABAPLINT_ABAPGIT_EXT</CLSNAME>
+    <LANGU>E</LANGU>
+    <DESCRIPT>aplint - Extension for abapGit (Definitions)</DESCRIPT>
+    <EXPOSURE>2</EXPOSURE>
+    <STATE>1</STATE>
+    <UNICODE>X</UNICODE>
+   </VSEOINTERF>
+  </asx:values>
+ </asx:abap>
+</abapGit>