added ReponseGroup parameter #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no parameter is set, all default responseGroups as before are used, so there shouldn't be any issue for existing usages.
|
@MarcL Please merge if you're fine with my changes. |
|
Hey @mrvnklm. Sorry, I don't really use this project myself so I've not looked at it in a long time. Your changes are ok but you've changed the signature of the methods by putting the response groups as a 2nd parameter so it's broken the current API. What do you think about putting this as the last parameter and defaulting it? If not, then we'll need to create a new major version with breaking API changes and needs documentation updating. Doesn't look like this will fix #29 as that's not supported in the API. Thanks, |
to avoid errors in current usage
|
@MarcL should be fine now, please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no parameter is set, all default responseGroups as before are used, so there shouldn't be any issue for existing usages.
Might help #29
Fixes #30