dummy formatting errors #9
Conversation
|
Error: The following files need to be formatted: You can find a formatting patch under Artifacts here or run |
MarcelKoch
force-pushed
the
formatting-dummy-changes
branch
from
a2d3f88
to
2b91b72
Compare
|
Error: The following files need to be formatted: You can find a formatting patch under Artifacts here or run |
|
check-format! |
|
Error: The following files need to be formatted: You can find a formatting patch under Artifacts here or run |
|
format! |
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
| repos: | ||
| - repo: https://github.com/pre-commit/mirrors-clang-format | ||
| rev: 'v14.0.0' # The default in Ubuntu 22.04, which is used in our CI | ||
| hooks: | ||
| - id: clang-format | ||
| types_or: [c, c++, cuda, inc] | ||
| exclude: third_party/SuiteSparse/AMD/.* |
There was a problem hiding this comment.
because it install clang-format by pip, I wonder it affects/updates the local python package without notification.
Do you know how pre-commit manages the python environment and whether we can use this clang-format in editor?
nit: use two space to be consistent with the other yaml format
| @@ -1,31 +0,0 @@ | |||
| find_package(Git QUIET) | |||
There was a problem hiding this comment.
It can still be pushed if the GINKGO_DEVEL_TOOLS=OFF, right?
The dummy hook is needed although user can still push repo directly before any cmake action.
| on: | ||
| workflow_call: |
There was a problem hiding this comment.
| on: | |
| workflow_call: | |
| on: workflow_call |
| @@ -30,7 +30,7 @@ git rebase --rebase-merges --empty=drop --no-keep-empty \ | |||
| --exec "cp /tmp/add_license.sh /tmp/format_header.sh /tmp/update_ginkgo_header.sh dev_tools/scripts/ && \ | |||
| dev_tools/scripts/add_license.sh && dev_tools/scripts/update_ginkgo_header.sh && \ | |||
| for f in \$($DIFF_COMMAND | grep -E '$FORMAT_HEADER_REGEX'); do dev_tools/scripts/format_header.sh \$f; done && \ | |||
| for f in \$($DIFF_COMMAND | grep -E '$FORMAT_REGEX'); do $CLANG_FORMAT -i \$f; done && \ | |||
| pipx run pre-commit run --files $TO_FORMAT && \ | |||
There was a problem hiding this comment.
$TO_FORMAT is defined in .github/format.sh but it is not sourced
|
Ah... I write the review on the wrong pr. |
No description provided.