Respect multi-fetch limit when fetching elements for conflict resolution #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpoole
force-pushed
the
always_respect_multi_fetch_limits
branch
2 times, most recently
from
6122ce1 to
c1b97b8
Compare
Multi-fetch API call URL lengths can easily exceed the maximum URL length. We currently limit the number of elements to 200 (same value as JOSM uses) and simply loop to process all ids if more are required. Note: this unifies and simplifies the code as this was already "fixed" for certain situations.
simonpoole
force-pushed
the
always_respect_multi_fetch_limits
branch
from
c1b97b8 to
a0161d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-fetch API call URL lengths can easily exceed the maximum URL length. We currently limit the number of elements to 685, that should work with up to 12 digit ids, and simply loop to process all ids if more are required.
Note: this unifies and simplifies the code as the issue was already fixed for certain situations.