Bump API target in build script #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpoole
force-pushed
the
target-34
branch
2 times, most recently
from
5519b66 to
46b3d54
Compare
Effects of this should largely be limited to image selection according to https://developer.android.com/about/versions/14/changes/partial-photo-video-access However, as normal, google contradicts itself in the document and is very unclear if the compatible mode it supposedly uses will go away at some time in the future and if it is any different to the previous behaviour. In any case at least on Android 14 emulators there currently doesn't seem to be any impact. Resolves: #2595
Upgrading roboelectric causes tests with SQLite use to fail, because of time constraints as a temporary fix we force use of SDK 33 for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects of this should largely be limited to image selection according to https://developer.android.com/about/versions/14/changes/partial-photo-video-access However, as normal, google contradicts itself in the document and is very unclear if the compatible mode it supposedly uses will go away at some time in the future and if it is any different to the previous behaviour. In any case at least on Android 14 emulators there currently doesn't seem to be any impact.
Resolves: #2595