Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional columns to public stats page #815

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

FlorianSW
Copy link
Collaborator

image

@Dorfieeee
Copy link
Collaborator

I haven't checked yet but we also need to make sure it's mobile friendly

@FlorianSW
Copy link
Collaborator Author

Looks as okay as before I would say. Without any optional columns (I already scrolled a bit to the right on both screenshots):
image
After:
image

@Dorfieeee
Copy link
Collaborator

Until you start searching for a player

@FlorianSW
Copy link
Collaborator Author

Until you start searching for a player

Good point. What about that:
image
And when searching:
image

It's basically just flex-wrap set to wrap 🤷

Copy link
Collaborator

@Dorfieeee Dorfieeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now. Let's use localeStorage next time so the table can persist user's preferences.

@FlorianSW FlorianSW force-pushed the feature/optional_columns_stats branch from ae320ca to e2c2db8 Compare January 4, 2025 17:37
@FlorianSW FlorianSW merged commit 924fed4 into master Jan 4, 2025
3 checks passed
@FlorianSW FlorianSW deleted the feature/optional_columns_stats branch January 4, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants