Overhaul scorebot; support editing messages in the webhook service; m… #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscellaneous typing updates
FlorianSW
approved these changes
Feb 17, 2025
| command=python -m rcon.scorebot | ||
| environment=LOGGING_FILENAME=scorebot_%(ENV_SERVER_NUMBER)s.log | ||
| startretries=24 | ||
| [program:scoreboard] |
There was a problem hiding this comment.
When doing a release, this should be explicitly mentioned. Some people (including me) have their "own" supervisord.conf, where they need to make these changes well
| @@ -63,6 +66,7 @@ x-supervisor: &supervisor | |||
| - ./logs:/logs/ | |||
| - ./supervisor_data:/data | |||
| - ./config:/config/ | |||
| - scoreboard_db:/scoreboard_db | |||
There was a problem hiding this comment.
another thing that needs to be documented, people are supposed to copy-paste this file iirc.
| @@ -122,6 +122,27 @@ class Faction(pydantic.BaseModel): | |||
| name: str | |||
| team: Team | |||
|
|
|||
| if TYPE_CHECKING: | |||
There was a problem hiding this comment.
wow, I didn't know about that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entrypoint.shto port legacy scorebot public stat URL/webhook URLs, we can remove this in a few releasesget_scorebot_configis still available as an endpoint so people can easily get their old settingsrcon.scoreboard.pytorcon.player_stats.pyto be more clear (and I wanted to use thescoreboardnamescoreboardto differentiate/make troubleshooting easier when supporting usersSo legacy scorebot used a single message and didn't contain a map rotation.
This splits the message into three sections, the header/game state, map rotation and player stats to help get around inherent Discord API limitations on message length/etc. This allows people to show off more player stats if they prefer.
It's very customizable; people can turn off individual sections/translate text for the different sections.
It also now works internally with an RCON instance instead of making requests through the docker network; the only mandatory settings are a public stats port, and at least one webhook URL which should be easier for users to configure.
I tested this locally and it seems to work just fine.