Skip to content

Commit

Permalink
Triplelift - update creativeId (prebid#3305)
Browse files Browse the repository at this point in the history
* removed dependancy on getTopWindowUrl for referer

* protect against undefined obj and remove test on old dependency

* added unit test for referer and gdpr in query string

* removed gdpr test

* removed gdpr from bidderRequest obj

* decontructed bidder request obj in chai test

* just need to run karma tests again

* added gdpr consent to all bidderRequest obj in chai tests

* changed creativeId to be a Triplelift specific id rather than represent SRA impression

* error-proofed creative id
  • Loading branch information
brittanyzellman authored and Pedro López Jiménez committed Mar 18, 2019
1 parent 7bd3590 commit 94fa0ac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modules/tripleliftBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,11 @@ function _buildResponseObject(bidderRequest, bid) {
let width = bid.width || 1;
let height = bid.height || 1;
let dealId = bid.deal_id || '';
let creativeId = bid.imp_id;
let creativeId = bid.crid || '';

if (bid.cpm != 0 && bid.ad) {
bidResponse = {
requestId: bidderRequest.bids[creativeId].bidId,
requestId: bidderRequest.bids[bid.imp_id].bidId,
cpm: bid.cpm,
width: width,
height: height,
Expand Down

0 comments on commit 94fa0ac

Please sign in to comment.