handles empty responses in getUserSyncs & add tests - ajaBidAdapter (p…

…rebid#3283)
Marfeel · Mar 18, 2019 · d0265d3 · d0265d3
1 parent 1788351
commit d0265d3
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/modules/ajaBidAdapter.js b/modules/ajaBidAdapter.js
@@ -93,7 +93,7 @@ export const spec = {
 
   getUserSyncs: function(syncOptions, serverResponses) {
     const syncs = [];
-    if (syncOptions.pixelEnabled) {
+    if (syncOptions.pixelEnabled && serverResponses.length) {
       const bidderResponseBody = serverResponses[0].body;
       if (bidderResponseBody.syncs) {
         bidderResponseBody.syncs.forEach(sync => {

diff --git a/test/spec/modules/ajaBidAdapter_spec.js b/test/spec/modules/ajaBidAdapter_spec.js
@@ -141,4 +141,46 @@ describe('AjaAdapter', function () {
       expect(result.length).to.equal(0);
     });
   });
+
+  describe('getUserSyncs', function () {
+    const bidResponse1 = {
+      body: {
+        'is_ad_return': true,
+        'ad': { /* ad body */ },
+        'syncs': [
+          'https://example.test/1'
+        ]
+      }
+    };
+
+    const bidResponse2 = {
+      body: {
+        'is_ad_return': true,
+        'ad': { /* ad body */ },
+        'syncs': [
+          'https://example.test/2'
+        ]
+      }
+    };
+
+    it('should use a sync url from first response', function () {
+      const syncs = spec.getUserSyncs({ pixelEnabled: true }, [bidResponse1, bidResponse2]);
+      expect(syncs).to.deep.equal([
+        {
+          type: 'image',
+          url: 'https://example.test/1'
+        }
+      ]);
+    });
+
+    it('handle empty response (e.g. timeout)', function () {
+      const syncs = spec.getUserSyncs({ pixelEnabled: true }, []);
+      expect(syncs).to.deep.equal([]);
+    });
+
+    it('returns empty syncs when not enabled', function () {
+      const syncs = spec.getUserSyncs({ pixelEnabled: false }, [bidResponse1]);
+      expect(syncs).to.deep.equal([]);
+    });
+  });
 });