MDBF-811 More Galera tests + 2404-debug test #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
force-pushed
the
more_galera
branch
2 times, most recently
from
b4c1075 to
91f4e3c
Compare
|
help. I can't work out what the worker is meant to be. |
master-docker-nonstandard/master.cfg
Outdated
| c["builders"].append( | ||
| util.BuilderConfig( | ||
| name="amd64-ubuntu-2404-debug", | ||
| workernames=workers["x64-bbw-ubuntu-2404-debug"], |
There was a problem hiding this comment.
This should be workers['x64-bbw-docker-ubuntu-2404-debug']
And the list contains the following actual workers:
constants.py
Outdated
| @@ -50,10 +50,14 @@ | |||
| builders_galera_mtr = [ | |||
| "aarch64-debian-12", | |||
| "amd64-fedora-39", | |||
| "amd64-fedora-40", | |||
| "amd64-ubuntu-2004-debug", | |||
There was a problem hiding this comment.
2004 it's a typo or do we want to add Galera tests to a Protected branches builder?
There was a problem hiding this comment.
typo. Thanks. Protected branch builders should be a bit more planned.
vladbogo
approved these changes
Aug 2, 2024
grooverdan
force-pushed
the
more_galera
branch
from
00dd5ef to
5bde2df
Compare
|
s390x load implications |
grooverdan
changed the title
grooverdan
force-pushed
the
more_galera
branch
from
5bde2df to
b5093e0
Compare
|
@grooverdan Spotted a bug in the codebase, if you can just update the PR please. it should be |
There's no - non-protected branch amd64 debug builder. Adding one is useful for more galera tests in debug mode.
It was odd seeing mostly ppc64le/s390x test failures. This was because these where the main tests of galera. Added Fedora-40 to test the current distro galera package. Add s390/ppc64le Ubuntu 2404 so that this tests there too to see if modern compilers cause any different behaviour. As there is no debug build of galera, added amd64-2404-debug as a builder so that there is coverage of galera in a debug build which has additional tests.
With MariaDB Operator doing UBI based container operatability with galera, more RHEL based galera tests needed to catch operability problems ealier.
Without it could be going out of support MariaDB/galera#32 (comment)
grooverdan
force-pushed
the
more_galera
branch
from
b5093e0 to
c855141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New Build template
Checklist