-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDBF-773 - QUAY,GHCR move / create tags for Production images #552
MDBF-773 - QUAY,GHCR move / create tags for Production images #552
Conversation
d6e769f
to
9a3e8c4
Compare
acb00d2
to
f3287ed
Compare
Make BB be environment aware when choosing the image tag. Development environment will use tags starting with dev_ - define CONTAINER_REGISTRY_URL environment variable for both Prod/Dev - default is required i.e. Production not running in containers
- pushes to other buildbot branch other than Main will create an image tagged with dev_ - forks / pull request - Only Build - pushes to Main will update the tags with skopeo copy on the same upstream registry
- forks / PR's won't build. Only checking the Dockerfile - pushes to other branches than Main will build and push a DEV_ tag - pushed to Main will update the tag with skopeo copy on the same upstream registry
- the release container will use DEV tags
aa535cd
to
018eda5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe consider moving the CONTAINER_REGISTRY_URL in the create_worker function and only pass the tag as a param when using addWorker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a really really nice improvement!
This PR is quite big (and I understand why), but it's difficult to be entirely sure with my review. To proceed I think that (after the small change requested), it's okay to merge to DEV and start verifying directly on the DEV infra that everything looks OK.
I don't see how this could impact production if merged only on dev
branch but probably other should confirm.
@fauust As for Production impact. |
@vladbogo so if I understand correctly, most of the time adding a worker follows the above steps: And we have a small percentage of workers which are defined directly without using the addWorker function but rather appending directly to c["workers"] list . Your suggestion is really good but I would keep this kind of refactoring for a different patch where we normalize all worker addition to follow the addWorker path. I'm a little bit concerned about adding it to this patch as there are already a lot of changes . |
Implement dev tag feature as per MDBF-773.
Scope:
Description:
Other improvements:
Considerations: