Rename constants to use capital letters consistently #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvicentiu
force-pushed
the
rename_constants
branch
from
66f3826 to
3dbe393
Compare
|
This PR is done, but will be merged after the previous refactoring ones are merged. |
cvicentiu
force-pushed
the
rename_constants
branch
10 times, most recently
from
cc261ab to
56ddb71
Compare
Start renaming constants to use capital letters consistently. branches_main -> BRANCHES_MAIN
github_status_builders -> GITHUB_STATUS_BUILDERS
1. Eliminate star imports. Import what you use. 2. Eliminate redundant f-strings without placeholders. 3. Fix wrong escape \ character in Windows-like paths. 4. Eliminate (some) long lines over 80 characters.
1. Introduce a new yml file that stores worker locks counts. 2. Remove redundant and inconsistent naming between lock name and worker name.
1. Introduce typehints 2. Include what you use.
No need to reconstruct the same list over and over, just return a static variable.
Simplify and ensure it returns a 3-value tuple.
Always pass in SAVED_PACKAGE_BRANCHES where it makes sense
cvicentiu
force-pushed
the
rename_constants
branch
from
19e99e9 to
8d1c0ed
Compare
cvicentiu
force-pushed
the
rename_constants
branch
from
8240c9f to
0225c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to refactor constants.py to declare constants as capital letters.