Adding env_var APP_HOST cause of security #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to add APP_HOST, because you used % for the user access. That isn't secure. root should have access on localhost and the created MYSQL_USER should use the IP address of the application server. I added APP_HOST for that.
security change for localhost
Contributor
|
This is actually being discussed over in docker-library/mysql#231 (and we'd like to see it updated in |
Contributor
|
Fixed via #102 🎈 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add APP_HOST, because you used % for the user access. That isn't secure. root should have access on localhost and the created MYSQL_USER should use the IP address of the application server. I added APP_HOST for that. I want to improve the security of the mariadb docker image with that.
Thanks!