Skip to content

use static methods where possible #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

use static methods where possible #4532

wants to merge 5 commits into from

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp
Copy link
Contributor Author

@rockfordlhotka is this something you want? if so i will handle the conflicts

@SimonCropp
Copy link
Contributor Author

@StefanOssendorf want me to handle the conflicts?

@StefanOssendorf
Copy link
Contributor

@StefanOssendorf want me to handle the conflicts?

Yes, why not? As far as I know this does boost performance in a slight way, right?

@rockfordlhotka
Copy link
Member

@SimonCropp yes, this looks good to me, please do resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockfordlhotka rockfordlhotka rockfordlhotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @StefanOssendorf @rockfordlhotka