Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added remaning Tests #6

Merged
merged 5 commits into from
Jan 25, 2022
Merged

Added remaning Tests #6

merged 5 commits into from
Jan 25, 2022

Conversation

AleexCaires
Copy link
Collaborator

Added tests for the remanning unites

@AleexCaires AleexCaires added the enhancement New feature or request label Jan 25, 2022
@AleexCaires AleexCaires self-assigned this Jan 25, 2022
@AleexCaires
Copy link
Collaborator Author

Last tests with 'pt' are failing, because we need to add a decimal case to the logic, so the result is( example: 1 instead of 1.000000755905604), when converting 'pt' to 'rem'.

Mario-Duarte
Mario-Duarte requested changes Jan 25, 2022
View reviewed changes
Copy link
Owner

@Mario-Duarte Mario-Duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment, I think your issue will be resolved by rounding the results in the useConvertUnits hook

@AleexCaires AleexCaires merged commit cebd22c into develop Jan 25, 2022
@AleexCaires AleexCaires deleted the Tests branch January 25, 2022 15:21
@Mario-Duarte Mario-Duarte self-requested a review January 25, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-Duarte Mario-Duarte Mario-Duarte requested changes

Assignees

@AleexCaires AleexCaires

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleexCaires @Mario-Duarte