Skip to content

Commit

Permalink
Rollup merge of rust-lang#52760 - cuviper:test_loading_atoi, r=alexcr…
Browse files Browse the repository at this point in the history
…ichton

rustc_metadata: test loading atoi instead of cos

Some platforms don't actually have `libm` already linked in the test
infrastructure, and then `dynamic_lib::tests::test_loading_cosine` would
fail to find the "cos" symbol.  Every platform running this test should
have `libc` and "atoi" though, so try to use that symbol instead.

Fixes rust-lang#45410.
  • Loading branch information
Mark-Simulacrum authored Jul 27, 2018
2 parents e10d1c3 + efa11da commit cda80f4
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions src/librustc_metadata/dynamic_lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,30 +90,29 @@ mod tests {
use std::mem;

#[test]
fn test_loading_cosine() {
fn test_loading_atoi() {
if cfg!(windows) {
return
}

// The math library does not need to be loaded since it is already
// statically linked in
let libm = match DynamicLibrary::open(None) {
// The C library does not need to be loaded since it is already linked in
let lib = match DynamicLibrary::open(None) {
Err(error) => panic!("Could not load self as module: {}", error),
Ok(libm) => libm
Ok(lib) => lib
};

let cosine: extern fn(libc::c_double) -> libc::c_double = unsafe {
match libm.symbol("cos") {
Err(error) => panic!("Could not load function cos: {}", error),
Ok(cosine) => mem::transmute::<*mut u8, _>(cosine)
let atoi: extern fn(*const libc::c_char) -> libc::c_int = unsafe {
match lib.symbol("atoi") {
Err(error) => panic!("Could not load function atoi: {}", error),
Ok(atoi) => mem::transmute::<*mut u8, _>(atoi)
}
};

let argument = 0.0;
let expected_result = 1.0;
let result = cosine(argument);
let argument = CString::new("1383428980").unwrap();
let expected_result = 0x52757374;
let result = atoi(argument.as_ptr());
if result != expected_result {
panic!("cos({}) != {} but equaled {} instead", argument,
panic!("atoi({:?}) != {} but equaled {} instead", argument,
expected_result, result)
}
}
Expand Down

0 comments on commit cda80f4

Please sign in to comment.