Migrate Page/index.js to TypeScript #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovyntls
changed the title
jovyntls
force-pushed
the
ts-migrate-page-indexjs
branch
2 times, most recently
from
8599ed2 to
47d24fe
Compare
jovyntls
added a commit
to jovyntls/markbind
that referenced
this pull request
Feb 16, 2023
jovyntls
force-pushed
the
ts-migrate-page-indexjs
branch
from
47d24fe to
111716f
Compare
jovyntls
changed the title
jovyntls
added a commit
to jovyntls/markbind
that referenced
this pull request
Feb 16, 2023
jovyntls
force-pushed
the
ts-migrate-page-indexjs
branch
from
111716f to
2c5070c
Compare
raysonkoh
reviewed
Feb 19, 2023
| pageConfig: PageConfig; | ||
| siteConfig: SiteConfig; | ||
|
|
||
| // We assert that these properties exist because resetState is called in the constructor to initialise them |
There was a problem hiding this comment.
Interesting, I didn't know this was possible in TS 🤔
packages/core/src/Page/index.ts
Outdated
| * object of {text: NAV_TEXT, level: NAV_LEVEL}. | ||
| * Used for page nav generation. | ||
| * @type {Object<string, Object>} | ||
| * object of used for page nav generation. |
There was a problem hiding this comment.
Nit: seems grammatically weird
jovyntls
added a commit
to jovyntls/markbind
that referenced
this pull request
Feb 19, 2023
jovyntls
force-pushed
the
ts-migrate-page-indexjs
branch
from
2c5070c to
3996208
Compare
jovyntls
force-pushed
the
ts-migrate-page-indexjs
branch
from
3996208 to
a0edaf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Migrate Page/index.js to TypeScript
Proposed commit message: (wrap lines at 72 characters)
(rebase commit)
Checklist: ☑️