Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate plugin tests to Typescript #2213

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

jovyntls
Copy link
Contributor

@jovyntls jovyntls commented Mar 14, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Part of #1913

Overview of changes:
Migrates the default plugins' tests to TS

Proposed commit message: (wrap lines at 72 characters)
(rebase commit)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jovyntls jovyntls force-pushed the ts-migrate-default-plugin-tests branch from 1dd1e1f to ca58274 Compare March 21, 2023 09:29
@jovyntls jovyntls marked this pull request as ready for review March 21, 2023 09:34
Copy link
Contributor

@raysonkoh raysonkoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovyntls jovyntls added this to the v4.1.1 milestone Mar 24, 2023
@jovyntls jovyntls merged commit f40580b into MarkBind:master Mar 25, 2023
@jovyntls jovyntls deleted the ts-migrate-default-plugin-tests branch March 25, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants