-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade fontawesome version to latest (v6) from v5 Resolves #2242 #2326
Conversation
@SPWwj This is great. In fact, this reduces the need for this to be included in V5 major release, as it will no longer be a breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SPWwj, some nits. Also, could you fill in the PR description to aid PR review?
Specifically:
- any problem encountered during the migration? any things to note for this migration?
- how to test your change
- from users' POV: what update do they need and what new icons are now available?
- what is the cost of keeping the current icons, if any?
- etc
PR description updated. There should be no impact from the users' POV based on FontAwesome's backward-compatibility. |
Will be helping out on this. |
.../cli/test/functional/test_site/expected/markbind/material-icons/material-icons-outlined.woff
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @SPWwj 🚀
@all-contributors please add @SPWwj for doc, code |
I've put up a pull request to add @SPWwj! 🎉 |
What is the purpose of this pull request?
Overview of changes:
Resolves #2242
Upgrade from fontawesome-free@5.15.4 to fontawesome-free@6.4.0.
The current icons will be preserved. In addition, this PR allows the use of FontAwesome v6 icons
For detail refer to backward-compatibility
Code:
Output:
Anything you'd like to highlight/discuss:
V6 has moved regular icons to the pro version.
However, the free icons in v5 should still be usable due to backward compatibility.
Thus user does not need to do anything and no cost in keeping current icons.
The fas and fab icons have been renamed to fa-solid and fa-brands, respectively.
Testing instructions:
Create a new project and try out the instructions provided in the Markbind Icon documentation,
with new v6 icons
Proposed commit message: (wrap lines at 72 characters)
Upgrade font awesome version to latest (v6) from v5
Checklist: ☑️
Migration Guide
We upgraded from fontawesome-free@5.15.4 to fontawesome-free@6.4.0.
The current icons will be preserved (i.e. you don't have to make any changes if you don't want to) due to Font Awesome's backward compatibility.
With Version 6
For details please refer to Font Awesome's changelog