Skip to content

Commit

Permalink
[JENKINS-74879] Use strikethrough on merged pull request name column
Browse files Browse the repository at this point in the history
https://issues.jenkins.io/browse/JENKINS-74879 reports that the
strikethrough text is no longer previously displayed when a pull request
has been merged or closed.  The strikethrough text is a nice visual
indicator that the job is no longer active.  Let's bring it back so that
the visual hint is still there for users.

The strikethrough text is displayed on the job page, but not in the
table of jobs for each pull request or branch.

Change was originally introduced when pull request titles were enabled
by default in the column name.  Refer to:

* jenkinsci#476

Assumed that it is better to drop the jenkins-table__link formatting in
the plugin rather than adjust the CSS definion in Jenkins core.  That CSS
definition has been in place in Jenkins core since Sep 2022 and likely
would have unexpected side effects if changed in core.  Refer to:

* jenkinsci/jenkins#6248

Testing done:

* Confirmed that the link has strikethrough text with this change.
* Confirmed that the non-striketrhrough link still looks good
  • Loading branch information
MarkEWaite committed Jan 3, 2025
1 parent 313fb0c commit c84807b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/resources/jenkins/branch/ItemColumn/column.jelly
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ THE SOFTWARE.
xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
<d:taglib uri="local">
<d:tag name="link">
<a href="${jobBaseUrl}${job.shortUrl}" class='model-link jenkins-table__link'>
<a href="${jobBaseUrl}${job.shortUrl}" class='model-link'>
<span>
<l:breakable value="${h.getRelativeDisplayNameFrom(job, itemGroup)}"/>
</span>
Expand Down

0 comments on commit c84807b

Please sign in to comment.