replaceDescription is not robust (jenkinsci#8307)

MarkEWaite · Jul 28, 2023 · 3172131 · 3172131
1 parent e1d6439
commit 3172131
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/core/src/main/resources/lib/hudson/editable-description.js b/core/src/main/resources/lib/hudson/editable-description.js
@@ -6,11 +6,7 @@
       e.preventDefault();
       let url = descriptionLink.getAttribute("data-url");
       let description = descriptionLink.getAttribute("data-description");
-      if (url == null && description == null) {
-        return replaceDescription();
-      } else {
-        return replaceDescription(description, url);
-      }
+      return replaceDescription(description, url);
     });
   });
 })();
diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js
@@ -1950,11 +1950,11 @@ function replaceDescription(initialDescription, submissionUrl) {
   d.firstElementChild.nextElementSibling.innerHTML =
     "<div class='jenkins-spinner'></div>";
   let parameters = {};
-  if (initialDescription !== undefined && submissionUrl !== undefined) {
-    parameters = {
-      description: initialDescription,
-      submissionUrl: submissionUrl,
-    };
+  if (initialDescription !== null && initialDescription !== "") {
+    parameters["description"] = initialDescription;
+  }
+  if (submissionUrl !== null && submissionUrl !== "") {
+    parameters["submissionUrl"] = submissionUrl;
   }
   fetch("./descriptionForm", {
     method: "post",