Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand menu_arguments #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expand menu_arguments #166

wants to merge 2 commits into from

Conversation

adityam
Copy link

@adityam adityam commented Feb 14, 2025

This patch expands the options specified in menu_arguments. This allows one to say:

    "menu_arguments": [
        "-dmenu",
        "-i",
        "-dpi",
        "$ROFI_DPI"
    ],

where $ROFI_DPI is a shell variable (and thereby open rofi with different DPIs on different machines).

@MarkHedleyJones MarkHedleyJones self-requested a review February 19, 2025 01:39
Copy link
Owner

@MarkHedleyJones MarkHedleyJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The changes look good. Are you able to manually increment the the version string from 1.2.4 to 1.3.0?
You can find it in pyproject.toml

Updating version number as requested
@adityam
Copy link
Author

adityam commented Feb 19, 2025

Thanks. I have updated the version string in pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants