Skip to content

Conversation

@Naragod
Copy link
Contributor

@Naragod Naragod commented Nov 4, 2025

Proposed Changes

This is a ✨ New feature (non-breaking change that adds functionality). We wish to be able to assign extra marks during test definitions.

If a test result returns the following structure:

{
  "extra_marks": [
    {
      "id": "a2d7f92c-4c89-4e7a-a9e9-a0a6caa391fa",
      "mark": 1,
      "fn": "extra_marks.py::test_with_bonus",
      "description": "This is a test mark",
      "unit": "points"
    }
  ]
}

We will now extract and make use of the extra_marks property to populate any extra marks we wish to assign during test execution.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

This is related to the following change:

@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2025

Pull Request Test Coverage Report for Build 19447493709

Details

  • 90 of 90 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.677%

Totals Coverage Status
Change from base Build 19439765710: 0.02%
Covered Lines: 43377
Relevant Lines: 46539

💛 - Coveralls

@Naragod Naragod requested a review from david-yz-liu November 5, 2025 19:12
@Naragod Naragod force-pushed the ISSUE-662_add_extra_marks_python_marker branch 2 times, most recently from ee6d1bc to 24ecde5 Compare November 10, 2025 15:50
@Naragod Naragod marked this pull request as draft November 12, 2025 15:04
@Naragod Naragod force-pushed the ISSUE-662_add_extra_marks_python_marker branch from 2d7104d to c98e96c Compare November 12, 2025 17:05
@Naragod Naragod requested a review from donny-wong November 12, 2025 20:26
@Naragod Naragod marked this pull request as ready for review November 12, 2025 20:26
@Naragod Naragod force-pushed the ISSUE-662_add_extra_marks_python_marker branch from c366193 to 0556dc9 Compare November 13, 2025 15:11
@donny-wong donny-wong removed their request for review November 14, 2025 15:26
@Naragod Naragod force-pushed the ISSUE-662_add_extra_marks_python_marker branch 2 times, most recently from 078f7db to a93945b Compare November 14, 2025 16:00
@Naragod Naragod requested a review from donny-wong November 14, 2025 18:08
@david-yz-liu
Copy link
Collaborator

@Naragod oh I forgot to mention in my review, please also update the sample test file to illustrate the new pytest marker.

@Naragod Naragod force-pushed the ISSUE-662_add_extra_marks_python_marker branch 4 times, most recently from 8c90ffa to 6facba4 Compare November 17, 2025 17:17
@Naragod Naragod force-pushed the ISSUE-662_add_extra_marks_python_marker branch from 48d665d to 79a1314 Compare November 17, 2025 18:32
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Naragod!

@david-yz-liu david-yz-liu merged commit 10c7738 into master Nov 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants