-
Notifications
You must be signed in to change notification settings - Fork 253
Issue 662 add extra marks python marker #7728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+178
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naragod
commented
Nov 4, 2025
Collaborator
Pull Request Test Coverage Report for Build 19447493709Details
💛 - Coveralls |
ee6d1bc to
24ecde5
Compare
2d7104d to
c98e96c
Compare
c366193 to
0556dc9
Compare
078f7db to
a93945b
Compare
donny-wong
reviewed
Nov 14, 2025
donny-wong
approved these changes
Nov 14, 2025
Collaborator
|
@Naragod oh I forgot to mention in my review, please also update the sample test file to illustrate the new pytest marker. |
8c90ffa to
6facba4
Compare
48d665d to
79a1314
Compare
david-yz-liu
approved these changes
Nov 19, 2025
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @Naragod!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is a ✨ New feature (non-breaking change that adds functionality). We wish to be able to assign extra marks during test definitions.
If a test result returns the following structure:
{ "extra_marks": [ { "id": "a2d7f92c-4c89-4e7a-a9e9-a0a6caa391fa", "mark": 1, "fn": "extra_marks.py::test_with_bonus", "description": "This is a test mark", "unit": "points" } ] }We will now extract and make use of the
extra_marksproperty to populate any extra marks we wish to assign during test execution.Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
This is related to the following change: