Migrate Course Summary Table to @tanstack/react-table v8 #7732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zie-liu/Markus into migrate-course-summary-table
Collaborator
Pull Request Test Coverage Report for Build 19452209077Details
💛 - Coveralls |
| const columnHelper = this.columnHelper; | ||
| return [ | ||
| columnHelper.accessor("hidden", { | ||
| id: "hidden", |
Collaborator
There was a problem hiding this comment.
This column is actually still appearing in the table (see screenshot below). I think this actually might be a problem with other v8 tables as well, I recall seeing it somewhere else. Please modify this code so that the column is fully hidden. You may need to change the underlying Table component implementation we've defined.
| columnHelper.accessor("hidden", { | ||
| id: "hidden", | ||
| filterFn: (row, columnId, filterValue) => { | ||
| if (filterValue) return true; // If filterValue true, show all rows |
Collaborator
There was a problem hiding this comment.
This code should be simplified; follow the same structure as the original implementation. You can leave a comment explaining what conditions are checked.
|
|
||
| updateShowHidden = event => { | ||
| let showHidden = event.target.checked; | ||
| let filtered = []; |
Collaborator
There was a problem hiding this comment.
You should not change this code other than the renaming of the state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Migrating the Course Summary Table to use @tanstack/react-table v8.
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)