Skip to content

Conversation

@freyazjiner
Copy link
Member

@freyazjiner freyazjiner commented Nov 18, 2025

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This PR passes the error_type field from the backend into the React table data. It also updates the test run table so that when a test group times out, the Status column shows a clear “timeout” label.

Screenshots of your changes (if applicable) image image
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@freyazjiner freyazjiner marked this pull request as ready for review November 18, 2025 03:22
@coveralls
Copy link
Collaborator

coveralls commented Nov 18, 2025

Pull Request Test Coverage Report for Build 19485179009

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 91.504%

Totals Coverage Status
Change from base Build 19439765710: -0.2%
Covered Lines: 43382
Relevant Lines: 46597

💛 - Coveralls

Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @freyazjiner, you've made a nice change on the back-end (I left one comment).

However on the front-end, we should not change the status of the overall test run. Instead, we should display a status for the test group result, because it's the individual test group results that can timeout. Note that each test group result currently has no display of status; I think you can modify the code so that a "timeout" status is only displayed when there's a timeout, and otherwise no status is displayed, preserving the current behaviour.

When you are verifying this, you should create two different test groups, one that times out and one that doesn't. This should result in two different "test group result" entries, where the "timeout" status is only shown on one of them. Please update the PR description screenshots with this change.

'test_results.name', 'test_results.status as test_results_status', 'test_results.marks_earned',
'test_results.marks_total', 'test_results.output', 'test_results.time', 'test_results.position']
fields << 'test_group_results.extra_info' if include_extra_info
fields << 'test_group_results.error_type'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be added to the larger list above; the only reason extra_info is by itself is that it is only conditionally included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants