-
Notifications
You must be signed in to change notification settings - Fork 253
Add timeout display to the test run table UI #7734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add timeout display to the test run table UI #7734
Conversation
Pull Request Test Coverage Report for Build 19485179009Details
💛 - Coveralls |
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @freyazjiner, you've made a nice change on the back-end (I left one comment).
However on the front-end, we should not change the status of the overall test run. Instead, we should display a status for the test group result, because it's the individual test group results that can timeout. Note that each test group result currently has no display of status; I think you can modify the code so that a "timeout" status is only displayed when there's a timeout, and otherwise no status is displayed, preserving the current behaviour.
When you are verifying this, you should create two different test groups, one that times out and one that doesn't. This should result in two different "test group result" entries, where the "timeout" status is only shown on one of them. Please update the PR description screenshots with this change.
| 'test_results.name', 'test_results.status as test_results_status', 'test_results.marks_earned', | ||
| 'test_results.marks_total', 'test_results.output', 'test_results.time', 'test_results.position'] | ||
| fields << 'test_group_results.extra_info' if include_extra_info | ||
| fields << 'test_group_results.error_type' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be added to the larger list above; the only reason extra_info is by itself is that it is only conditionally included.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This PR passes the
error_typefield from the backend into the React table data. It also updates the test run table so that when a test group times out, the Status column shows a clear “timeout” label.Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)