Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass parameters list to cursor.execute #198

Merged
merged 17 commits into from
Nov 20, 2023
Merged

Conversation

bhirsz
Copy link
Member

@bhirsz bhirsz commented Nov 19, 2023

Recreated from #183 (retained original commits, only rebased and updated the code).

carnegiemedal and others added 7 commits November 19, 2023 17:01
add parameters argument
pass parameters argument to execute function
added test using parameters argument
use correct list parameter
try different syntax for postgres, oracle etc.
extra syntax alternative for postgres, pymsql
):
"""
Uses the input ``selectStatement`` to query for the values that will be returned as a list of tuples. Set
optional input ``sansTran`` to True to run command without an explicit transaction commit or rollback.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all Set Optional.. sentences because they are already in the doc string - at the bottom (so we had it twice for every keyword).

@bhirsz bhirsz mentioned this pull request Nov 19, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d562452) 100.00% compared to head (e929dc0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           27        27           
=========================================
  Hits            27        27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amochin amochin merged commit 170050b into master Nov 20, 2023
22 checks passed
@amochin amochin deleted the feature/execute_parameters branch August 15, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants